Skip to content

logname: reduce range of unsafe block#11506

Merged
cakebaker merged 1 commit intouutils:mainfrom
oech3:logname-unsafe
Mar 26, 2026
Merged

logname: reduce range of unsafe block#11506
cakebaker merged 1 commit intouutils:mainfrom
oech3:logname-unsafe

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 26, 2026

No description provided.

@oech3 oech3 marked this pull request as ready for review March 26, 2026 11:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/tail-n0f. tests/tail/tail-n0f is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/cp/link-heap is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 26, 2026

Merging this PR will degrade performance by 11.96%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 299 untouched benchmarks
⏩ 46 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory cp_recursive_deep_tree[(120, 4)] 615.6 KB 699.2 KB -11.96%

Comparing oech3:logname-unsafe (640a3ad) with main (37d07e4)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@cakebaker cakebaker merged commit 230e0cf into uutils:main Mar 26, 2026
160 of 162 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Mar 26, 2026

Thanks!

@oech3 oech3 deleted the logname-unsafe branch March 26, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @cakebaker